This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Pause and retry ipset deletion if it fails the first time #3851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Agreed this is not ideal but will hopefully improve symptoms in the short term. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue (#3847) with using both
iptablesin thenftmode andipseton modern kernels (for example, the ones used by CentOS 8 or Ubuntu 20.04). If an ipset is being destroyed right after deleting a referencing rule then there is a good chance that theipset destroycommand will fail with a"Set cannot be destroyed: it is in use by a kernel component"error.The more permanent solution would be retiring
ipsetandiptables-nftaltogether, fully migrating to nftables and leveraging its native data types support instead of the IP sets.This might be a lengthy process, so this PR offers a temporary solution until then: a second try after a 100ms pause that gets triggered if
ipset destroyfails.